Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3325 #3313 #3328 - each() function fixes #3333

Merged
merged 1 commit into from
Nov 29, 2018
Merged

Fixes #3325 #3313 #3328 - each() function fixes #3333

merged 1 commit into from
Nov 29, 2018

Conversation

matthew-dean
Copy link
Member

No description provided.

calvinjuarez
calvinjuarez approved these changes Nov 28, 2018
View reviewed changes
Copy link
Member

@calvinjuarez calvinjuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests seem solid. Failing tests are the same old PhantomJS tests, and the jasmine:rootpathRelative one from the other PR. They may merit investigation, but importantly, functions-each is passing in both Travis and AppVeyor

@matthew-dean matthew-dean merged commit c816d82 into less:master Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvinjuarez calvinjuarez calvinjuarez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthew-dean @calvinjuarez