Fix #3576 import redirects. Replace native-request with needle. #3582
Conversation
|
Hmm, apprently |
|
Btw, I noticed that on AppVeyor all builds are done with node version 8 and from the environment names seems like the objective was to test with different node versions. |
| @@ -0,0 +1,3 @@ | |||
| @import "https://example.com/redirect.less"; | |||
There was a problem hiding this comment.
Is this something that will always redirect? As in, will this test always succeed with this remote endpoint?
There was a problem hiding this comment.
This is the url nock mocks, so node doesn't actually send the request to a remote server. So as long as nock is set up to intercept this exact url it will always redirect.
| (() => { | ||
| // Create new tester, since tests are not independent and tests | ||
| // above modify tester in a way that breaks remote imports. | ||
| lessTester = lessTest(); |
There was a problem hiding this comment.
If remote imports are being broken between tests, where do you think would be the best place to fix this? Is this a problem in Less itself? Or a problem in the way tests are set up?
There was a problem hiding this comment.
I think the problem is in the way tests are set up. Ideally tests should be independent, meaning each test should have it's own instance of less, even more so since the less instance is modified by some tests. Or, alternatively, each test should have a tear down part, where it returns less instance to it's initial (before test) state. However, if I understand correctly tests are also run concurrently, which might be a problem for the set up / tear down approach.
I suspect the reason remote imports get broken is because of plugin tests, might be wrong here, haven't actually investigated it.
One way to approach this is to define a function with contents of less-node/index.js and call it in less-node/index.js and before each test.
There was a problem hiding this comment.
I don't believe tests are run concurrently. They're run in a queue. But definitely it's possible they mutate the less object or don't return it to previous state. However, I doubt that's intentional, so it would be great to track it down, but maybe that's out of the scope of this issue.
This may be an oversight. Node versions have been incremented over time to support, I think, the last 4 major Node versions. Environment vars may not hav been kept in sync. Thanks for the PR! I left some comments / questions on it. |
| @@ -0,0 +1,3 @@ | |||
| @import "https://example.com/redirect.less"; | |||
Quick overview of the changes:
native-requestwith needle - hopefully small enough http client to not be a burden.logger.addListenercall outside oflessTesterfactory function inless/test/less-test.js. This was necessary to avoid registering the same listeners twice as for the test it was necessary to instantiatelessTesterone more time.lessTesterinless/test/index.js. This is necessary since tests in the test suite are not isolated and leavelessinstance in the state in which remote imports are completely broken.