Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix currentFileInfo and index properties on nodes #3602

Merged
merged 1 commit into from
Feb 8, 2021

Commits on Feb 4, 2021

  1. Fix currentFileInfo and index properties on nodes

    These fields are accessed by other tools such as parcel (for resolving local
    asset URLs). As per 257efdd the behavior with
    (at least) parcel for relative paths in sub-directries changed. Prior to that
    commit (last release 3.12.2) assets were resolved relative to the less module
    that contains the `url(..)`. From release 3.13.0 parcel resolves assets relative
    to the root less module, because no `currentFileInfo` is available.
    
    This is caused by tree nodes setting their prototype to an instance of
    `Node`. This leaves the `self` reference in `Node`s constructor pointing to the
    prototype, not the actual instance the data is set on. Replacing this with
    properties defined on `Node`s prototype fixes this.
    bjpbakker committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    a0fb5a2 View commit details
    Browse the repository at this point in the history