implement dialog.open #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was going to accept this without testing, but I was lucky to have merged the slack server mock before that... the Travis CI failure (https://travis-ci.org/lestrrat/go-slack/jobs/314643784) means you haven't defined a stock response variable that we would be returning for this dialog operation. Once you define it, you should be able to use the mock app to test your client method, too! |
|
My bad. Forgot to run go test before commit... I tested it when writing my own app. The test should pass now. |
|
Since I don't and probably will not use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I implement the missing
dialog.openAPI, plz review.Also I added the
trigger_idfield inInteractiveButtonRequest, which is needed to open a dialog.The new
DialogSubmissionstruct is very similar toInteractiveButtonRequest, I didn't try to merge the two, maybe it can be done in the future.