SA or RA should log failures from UpdatePendingAuthorization.
#2303
Comments
cpu
pushed a commit
that referenced
this issue
Nov 10, 2016
This commit resolves #2303 by updating the comment, and returned error type produced when the RA calls `SA.UpdatePendingAuthorization` and it fails. Previously this produced a `MalformedRequestError` that was described as only happening when the client corrupted the challenge data. Now this is returned as more descriptive `ServerInternalError` and the underlying error from the SA is logged as a warning for further debugging.
jsha
pushed a commit
that referenced
this issue
Nov 11, 2016
This commit resolves #2303 by updating the comment, and returned error type produced when the RA calls `SA.UpdatePendingAuthorization` and it fails. Previously this produced a `MalformedRequestError` that was described as only happening when the client corrupted the challenge data. Now this is returned as more descriptive `ServerInternalError` and the underlying error from the SA is logged as a warning for further debugging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Presently when the RA performs an RPC call to the SA's
UpdatePendingAuthorizationfunction it discards any returned errors and instead produces a more generic malformed error for the client.While we say "This can pretty much only happen when the client corrupts the Challenge data." it can also occur during database outages and it would be helpful if the RA or the SA logged which part of the underlying operation failed (finding the authz, updating challenges, etc). Presently it is difficult to work backwards from a "Challenge data was corrupted" error to a root cause.
We should also update the comment & error message to better reflect that this can be caused by server-side conditions and not strictly "malformed" input.
The text was updated successfully, but these errors were encountered: