Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update revision-pinned dependencies to release #2315

Closed
9 tasks done
cpu opened this issue Nov 7, 2016 · 11 comments
Closed
9 tasks done

Update revision-pinned dependencies to release #2315

cpu opened this issue Nov 7, 2016 · 11 comments

Comments

@cpu
Copy link
Contributor

cpu commented Nov 7, 2016

I ran Boulder through glide-report -no-color to try and identify dependencies we are pinning to a revision instead of a release, or have fallen behind from the latest release.

The following imports were all "Using development revision between Semantic Version releases":

For each of the above, we should either the update the dependency (following the CONTRIBUTING.md process!) to a semantic version release, or document why we are pinned to a specific development revision.

@cpu
Copy link
Contributor Author

cpu commented Nov 7, 2016

Updated to mark go-safe-browsing-api and cfssl as not-required and in-progress respectively. The CFSSL pr (#2170) needs some tests fixed and to be confirmed as updating to a release and not another dev commit.

@rolandshoemaker
Copy link
Contributor

Could you provide a rational for only using release versions instead of commits? Often we need to make changes to upstream libraries which would then be blocked on waiting for a new release including that change to be made.

@cpu
Copy link
Contributor Author

cpu commented Nov 7, 2016

@rolandshoemaker I don't think we need to stop the practice of pinning to a commit when we're waiting on upstream libraries to include changes we need, I just think that should be a documented event and we should aim to be using releases for everything else. I think it makes it easier to stay on top of security updates in upstream libraries this way. Does that make sense?

@rolandshoemaker
Copy link
Contributor

Yup, works for me.

@jsha jsha modified the milestone: Sprint 2016-11-08 Nov 8, 2016
@cpu cpu self-assigned this Nov 22, 2016
cpu pushed a commit that referenced this issue Nov 22, 2016
This commit updates the cactus `go-statsd-client` to the 2.0.2 release
tag.

Note: the most recent release is 3.1.0 but the introduction of
substatter support in 3.0.0 changes the `Statter` interface we rely on
in the boulder metrics package. We should consider follow-up work to
refactor our metrics code to be compatible with the 3.x releases.

Relates to #2315.
@cpu
Copy link
Contributor Author

cpu commented Nov 22, 2016

Our github.com/go-sql-driver/mysql dependency is pinned to a specific revision off of the 1.2 release. Ideally we would bump this to the latest tagged release but upstream is not yet using semantic versioning and there is significant work in master since the 1.2 release with no 1.3 tag available. I propose we update this dep to master and revisit when there is a 1.3 release.

@cpu
Copy link
Contributor Author

cpu commented Nov 22, 2016

We're pinned to 880ee4c335489bc78d01e4d0a254ae880734bc15 for github.com/jmhodges/clock, which is currently master's tip and newer than the 1.0 tagged release. There's nothing to do for this dep. unless upstream cuts a release.

@jsha
Copy link
Contributor

jsha commented Nov 22, 2016

I can ping upstream for github.com/jmhodges/clock.

@jsha
Copy link
Contributor

jsha commented Nov 22, 2016

Upstream Clock now has a v1.1.

rolandshoemaker pushed a commit that referenced this issue Nov 23, 2016
This commit updates the cactus `go-statsd-client` to the 2.0.2 release
tag.

Note: the most recent release is 3.1.0 but the introduction of
substatter support in 3.0.0 changes the `Statter` interface we rely on
in the boulder metrics package. We should consider follow-up work to
refactor our metrics code to be compatible with the 3.x releases.

Relates to #2315.
@cpu
Copy link
Contributor Author

cpu commented Nov 25, 2016

Added a comment for github.com/matttproud/golang_protobuf_extensions. There's only a v1.0.0 release and we're pinned to the tip of master, which is only two minor commits ahead of v1.0.0. It doesn't seem worth bugging upstream for a v1.0.1 release, especially for a transitive import.

@cpu
Copy link
Contributor Author

cpu commented Nov 28, 2016

RE: the merged Prometheus client update, from @jsha:

Note: This actually takes us to a slightly earlier revision of the Prometheus client (v0.8.0 was cut Aug 17, but we were previously vendored to an Oct 26 commit). However, it doesn't lose us any functionality or bug fixes. It gains us a couple of spelling errors in comments, but that's no big deal. I think it's worthwhile to take this patch in order to be vendored at a specific semver release.

@cpu
Copy link
Contributor Author

cpu commented Nov 29, 2016

Added PKCS11Key to the list with #2369

@cpu cpu closed this as completed Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants