Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leading path is stripped from the 'endpoint' field of the logEvent object #2328

Closed
rolandshoemaker opened this issue Nov 15, 2016 · 0 comments · Fixed by #2334
Closed

Leading path is stripped from the 'endpoint' field of the logEvent object #2328

rolandshoemaker opened this issue Nov 15, 2016 · 0 comments · Fixed by #2334
Assignees
@rolandshoemaker
Labels
area/wfe kind/bug
Milestone
Sprint 2016-11-15

Comments

@rolandshoemaker
Copy link
Contributor

When logging the endpoint a request was made to we expect the full path to be included. Because we use http.StripPrefix when passing into wfe.topHandler this isn't the case.
@rolandshoemaker rolandshoemaker self-assigned this Nov 15, 2016
@rolandshoemaker rolandshoemaker mentioned this issue Nov 17, 2016
Merged
@cpu cpu closed this as completed in #2334 Nov 19, 2016
cpu pushed a commit that referenced this issue Nov 19, 2016
@cpu
Actually log the endpoint we are serving (#2334)
d52c13f 
We use `http.StripPrefix` so handlers don't have to deal with stripping the boring part of URLs that they don't need (#1881). This caused either an empty string or only the ID from the path to be logged as the `endpoint` which was not useful for debugging. By doing the logging in the constructor instead we still have access to the prefix part of the path and can use it to reconstruct the full path.

Fixes #2328.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rolandshoemaker rolandshoemaker

Labels
area/wfe kind/bug
Projects
None yet
Milestone
Sprint 2016-11-15
Development

Successfully merging a pull request may close this issue.

Log the endpoint we are serving letsencrypt/boulder
1 participant
@rolandshoemaker