refactor: remove get_current_user
and replace with direct header read
#1834
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr refactor the way we get
user_id
from the header to be stateless (fixing a race condition bug)Currently incoming requests get the
user_id
by polling the server for the current user withget_current_user
, which reads from a variable:This variable is set by middleware inside of
rest_api.app
:This code is pretty bad since it clearly allows for race conditions (this was meant to be temporary code during the integration refactor).
This PR refactors the routes to instead do a simple read of the
user_id
from the request headers. If the client did not ser theuser_id
in the header, then the server will simply use the default user.