Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch errors with OllamaProvider #1875

Merged
merged 2 commits into from
Oct 13, 2024
Merged

Conversation

cpacker
Copy link
Collaborator

@cpacker cpacker commented Oct 13, 2024

OllamaProvider had some errors including runtime errors on the context window / embedding size fetch, also it didn't properly set the model wrapper / prompt formatter.

Copy link
Collaborator

@sarahwooders sarahwooders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sarahwooders sarahwooders merged commit 1842fd1 into main Oct 13, 2024
15 checks passed
@cpacker cpacker deleted the ollama-split-provider branch October 13, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants