Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch runtime error with personas #221

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Patch runtime error with personas #221

merged 1 commit into from
Oct 31, 2023

Conversation

cpacker
Copy link
Collaborator

@cpacker cpacker commented Oct 31, 2023

Was incorrectly doing personas.DEFAULT_PRESET, typo should have been personas.DEFAULT


Link to comment: #67 (comment)

root@mx:/# memgpt --model airoboros-l2-70b-2.1
Warning: Running legacy run command. Run memgpt run instead.
? Continue with legacy CLI? Yes
⚙️ Using legacy command line arguments.
╭─────────────────────────────── Traceback (most recent call last) ────────────────────────────────╮
│ /usr/local/lib/python3.10/site-packages/memgpt/main.py:169 in legacy_run │
│ │
│ 166 │ │ return │
│ 167 │ │
│ 168 │ loop = asyncio.get_event_loop() │
│ ❱ 169 │ loop.run_until_complete( │
│ 170 │ │ main( │
│ 171 │ │ │ persona, │
│ 172 │ │ │ human, │
│ │
│ ╭─────────────────────────────────────────── locals ───────────────────────────────────────────╮ │
│ │ archival_storage_faiss_path = '' │ │
│ │ archival_storage_files = '' │ │
│ │ archival_storage_files_compute_embeddings = '' │ │
│ │ archival_storage_sqldb = '' │ │
│ │ ctx = <click.core.Context object at 0x7f522181b6d0> │ │
│ │ debug = False │ │
│ │ first = False │ │
│ │ human = None │ │
│ │ loop = <_UnixSelectorEventLoop running=False │ │
│ │ closed=False debug=False> │ │
│ │ model = 'airoboros-l2-70b-2.1' │ │
│ │ no_verify = False │ │
│ │ persona = None │ │
│ │ use_azure_openai = False │ │
│ ╰──────────────────────────────────────────────────────────────────────────────────────────────╯ │
│ │
│ /usr/local/lib/python3.10/asyncio/base_events.py:649 in run_until_complete │
│ │
│ 646 │ │ if not future.done(): │
│ 647 │ │ │ raise RuntimeError('Event loop stopped before Future completed.') │
│ 648 │ │ │
│ ❱ 649 │ │ return future.result() │
│ 650 │ │
│ 651 │ def stop(self): │
│ 652 │ │ """Stop running the event loop. │
│ │
│ ╭─────────────────────────────────────────── locals ───────────────────────────────────────────╮ │
│ │ future = <Task finished name='Task-11' coro=<main() done, defined at │ │
│ │ /usr/local/lib/python3.10/site-packages/memgpt/main.py:186> │ │
│ │ exception=AttributeError("module 'memgpt.personas.personas' has no attribute │ │
│ │ 'DEFAULT_PRESET'")> │ │
│ │ new_task = True │ │
│ │ self = <_UnixSelectorEventLoop running=False closed=False debug=False> │ │
│ ╰──────────────────────────────────────────────────────────────────────────────────────────────╯ │
│ │
│ /usr/local/lib/python3.10/site-packages/memgpt/main.py:232 in main │
│ │
│ 229 │ │ memgpt_persona = persona │
│ 230 │ │ if memgpt_persona is None: │
│ 231 │ │ │ memgpt_persona = ( │
│ ❱ 232 │ │ │ │ personas.GPT35_DEFAULT if "gpt-3.5" in model else personas.DEFAULT_PRESE │
│ 233 │ │ │ │ None, # represents the personas dir in pymemgpt package │
│ 234 │ │ │ ) │
│ 235 │ │ else: │
│ │
│ ╭────────────────────────────── locals ──────────────────────────────╮ │
│ │ archival_storage_faiss_path = '' │ │
│ │ archival_storage_files = '' │ │
│ │ archival_storage_files_compute_embeddings = '' │ │
│ │ archival_storage_sqldb = '' │ │
│ │ azure_vars = [] │ │
│ │ debug = False │ │
│ │ first = False │ │
│ │ human = None │ │
│ │ memgpt_persona = None │ │
│ │ model = 'airoboros-l2-70b-2.1' │ │
│ │ no_verify = False │ │
│ │ persona = None │ │
│ │ use_azure_openai = False │ │
│ ╰────────────────────────────────────────────────────────────────────╯ │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
AttributeError: module 'memgpt.personas.personas' has no attribute 'DEFAULT_PRESET'

Copy link
Collaborator Author

@cpacker cpacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no other instances of personas.DEFAULT_P* in codebase

@cpacker cpacker merged commit 0a075f4 into main Oct 31, 2023
1 check passed
@cpacker cpacker deleted the personas-hotfix branch October 31, 2023 18:43
mattzh72 pushed a commit that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant