Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed load loading from wrong directory #237

Merged
merged 2 commits into from
Nov 1, 2023
Merged

fixed load loading from wrong directory #237

merged 2 commits into from
Nov 1, 2023

Conversation

cpacker
Copy link
Collaborator

@cpacker cpacker commented Nov 1, 2023

Closes #235

@cpacker
Copy link
Collaborator Author

cpacker commented Nov 1, 2023

Need to patch pickling on FAISS to solve final issue:

> Enter your message: /save
Saved checkpoint to: /Users/loaner/.memgpt/saved_state/2023-11-01_01_23_31_AM_PDT-0700.json
Saving persistence manager to /Users/loaner/.memgpt/saved_state/2023-11-01_01_23_31_AM_PDT-0700.persistence.pickle failed with: 'NoneType' object is not callable
⚙️ Saved config file to /Users/loaner/.memgpt/configs/2023-11-01_01_22_47_AM_PDT-0700.json.
> Enter your message: /load
/load warning: no checkpoint specified, loading most recent checkpoint from /Users/loaner/.memgpt/saved_state instead
Loaded checkpoint /Users/loaner/.memgpt/saved_state/2023-11-01_01_23_31_AM_PDT-0700.json
/load warning: loading persistence manager from /Users/loaner/.memgpt/saved_state/2023-11-01_01_23_31_AM_PDT-0700.persistence.pickle failed with: Ran out of input

But good to merge otherwise.

@cpacker cpacker requested a review from vivi November 1, 2023 08:26
vivi
vivi approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@vivi vivi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM you dropped this 👑

@cpacker
Copy link
Collaborator Author

cpacker commented Nov 1, 2023

This is also related to #205

I believe to close #205 we need to patch FAISS @vivi

@cpacker cpacker merged commit a269ffd into main Nov 1, 2023
1 check passed
@cpacker cpacker deleted the fix-load branch November 1, 2023 08:28
This was referenced Nov 3, 2023
Closed
Closed
mattzh72 pushed a commit that referenced this pull request Oct 9, 2024
@cpacker
fixed load loading from wrong directory (#237)
48020dc 
* fixed load loading from wrong directory

* typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivi vivi vivi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/load pulls wrong file by default
2 participants
@cpacker @vivi