Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Chunk inserts into DB on CLI load #994

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

sarahwooders
Copy link
Collaborator

Please describe the purpose of this pull request.
Currently on memgpt load, all the generated passages are inserted at once, which is problematic for large data loads.

Related issues or PRs
#988

Is your PR over 500 lines of code?
No

@sarahwooders sarahwooders requested a review from cpacker February 12, 2024 21:08
@sarahwooders sarahwooders changed the title Chunk inserts into DB on CLI load fix: Chunk inserts into DB on CLI load Feb 12, 2024
Copy link
Collaborator

@cpacker cpacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarahwooders sarahwooders merged commit 8d6e75f into main Feb 12, 2024
4 of 5 checks passed
norton120 pushed a commit to norton120/MemGPT that referenced this pull request Feb 15, 2024
@cpacker cpacker deleted the chunk_load_insert branch March 6, 2024 00:47
mattzh72 pushed a commit that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants