Change to upsert

src/app/components/editor.test.tsx

@@ -470,7 +470,7 @@ describe('QuestionSetEditor', () => {
       .setName('Test name')
       .appendQuestion()
       .build()
-    questionSetRepo.addQuestionSet(questionSet)
+    questionSetRepo.upsertQuestionSet(questionSet)
 
     const interactor = new UIServiceInteractor({
       questionSetName: 'Test name',

src/app/components/editor.tsx

@@ -4,7 +4,7 @@ import { useState } from 'react'
 import {
   QuestionSetRepo,
   LocalStorageQuestionSetRepo,
-  AddQuestionSetError,
+  UpsertQuestionSetError,
 } from '../../repo/question_set'
 import { Question, QuestionSet } from '../../model/question_set'
 import { MultipleChoiceBuilder, MultipleChoiceError } from '../../model/mc'
@@ -162,9 +162,9 @@ function QuestionSetEditor({
     })
 
     try {
-      questionSetRepo.addQuestionSet(questionSet)
+      questionSetRepo.upsertQuestionSet(questionSet)
     } catch (e) {
-      if (e instanceof AddQuestionSetError) {
+      if (e instanceof UpsertQuestionSetError) {
         if (e.cause.code === 'DUPLICATE_QUESTION_SET_NAME') {
           setErrorMessage('Question set with same name already exists')
           return

src/app/components/home.test.tsx

@@ -52,6 +52,6 @@ function renderHomePage({
   questionSets: readonly QuestionSet[]
 }) {
   const questionSetRepo = LocalStorageQuestionSetRepo.createNull()
-  questionSets.forEach((set) => questionSetRepo.addQuestionSet(set))
+  questionSets.forEach((set) => questionSetRepo.upsertQuestionSet(set))
   return render(HomePageUIService.createNull({ questionSetRepo }).getElement())
 }

src/app/components/quiz.test.tsx

@@ -236,7 +236,7 @@ function renderMultipleChoicePage({
   questionSet: QuestionSet
 }) {
   const originalQuestionSetRepo = LocalStorageQuestionSetRepo.createNull()
-  originalQuestionSetRepo.addQuestionSet(questionSet)
+  originalQuestionSetRepo.upsertQuestionSet(questionSet)
 
   const lastSubmittedQuestionSetRepo = LocalStorageQuestionSetRepo.createNull()
 

src/app/components/quiz.tsx

@@ -62,7 +62,7 @@ export class MultipleChoiceQuizUIService {
           this.originalQuestionSetRepo.getQuestionSetById(this.questionSetId)
         }
         recordSubmittedQuestionSet={(questionSet) =>
-          this.lastSubmittedQuestionSetRepo.addQuestionSet(questionSet)
+          this.lastSubmittedQuestionSetRepo.upsertQuestionSet(questionSet)
         }
       ></MultipleChoiceQuiz>
     )

src/repo/question_set.test.ts

@@ -2,7 +2,7 @@ import { MultipleChoiceBuilder } from '../model/mc'
 import { QuestionSet, QuestionSetBuilderForTest } from '../model/question_set'
 import {
   LocalStorageQuestionSetRepo,
-  AddQuestionSetError,
+  UpsertQuestionSetError,
   GetQuestionSetError,
   QuestionSetRepo,
 } from './question_set'
@@ -27,7 +27,7 @@ describe('LocalStorageQuestionSetRepo', () => {
   })
 
   it('should add question set and get question set by name', () => {
-    repo.addQuestionSet(questionSet)
+    repo.upsertQuestionSet(questionSet)
     expect(repo.getQuestionSetByName(questionSet.name)).toEqual(questionSet)
   })
 
@@ -38,16 +38,23 @@ describe('LocalStorageQuestionSetRepo', () => {
     )
   })
 
-  it('should throw error when question set name is taken', () => {
-    repo.addQuestionSet(questionSet)
-    expect(() => repo.addQuestionSet(questionSet)).toThrowCustomError(
-      AddQuestionSetError,
+  it('should throw error when question set name is taken by other questionSet', () => {
+    repo.upsertQuestionSet(questionSet)
+
+    const anotherQuestionSet = new QuestionSetBuilderForTest()
+      .setName(questionSet.name)
+      .build()
+    expect(() => repo.upsertQuestionSet(anotherQuestionSet)).toThrowCustomError(
+      UpsertQuestionSetError,
       'DUPLICATE_QUESTION_SET_NAME',
     )
+
+    // should not throw error when just updating the same question set
+    repo.upsertQuestionSet(questionSet)
   })
 
   it('should add question set and get question set by id', () => {
-    repo.addQuestionSet(questionSet)
+    repo.upsertQuestionSet(questionSet)
     expect(repo.getQuestionSetById(questionSet.id)).toEqual(questionSet)
   })
 
@@ -60,8 +67,8 @@ describe('LocalStorageQuestionSetRepo', () => {
 
   it('should get all question sets for added', () => {
     const questionSet2 = new QuestionSetBuilderForTest().setName('2').build()
-    repo.addQuestionSet(questionSet)
-    repo.addQuestionSet(questionSet2)
+    repo.upsertQuestionSet(questionSet)
+    repo.upsertQuestionSet(questionSet2)
     expect(repo.getQuestionSets()).toEqual([questionSet, questionSet2])
   })
 

src/repo/question_set.ts

@@ -4,9 +4,9 @@ import { LocalStorageOperator } from '../utils/local_storage'
 
 export interface QuestionSetRepo {
   /**
-   * @throws {AddQuestionSetError}
+   * @throws {UpsertQuestionSetError}
    */
-  addQuestionSet(questionSet: QuestionSet): void
+  upsertQuestionSet(questionSet: QuestionSet): void
 
   /**
    * @throws {GetQuestionSetError}
@@ -24,9 +24,9 @@ export interface QuestionSetRepo {
   getQuestionSets(): ReadonlyArray<QuestionSet>
 }
 
-type AddQuestionSetErrorCode = 'DUPLICATE_QUESTION_SET_NAME'
-export class AddQuestionSetError extends CustomBaseError<AddQuestionSetErrorCode> {
-  constructor(code: AddQuestionSetErrorCode, message?: string) {
+type UpsertQuestionSetErrorCode = 'DUPLICATE_QUESTION_SET_NAME'
+export class UpsertQuestionSetError extends CustomBaseError<UpsertQuestionSetErrorCode> {
+  constructor(code: UpsertQuestionSetErrorCode, message?: string) {
     super(code, message)
   }
 }
@@ -63,13 +63,13 @@ export class LocalStorageQuestionSetRepo implements QuestionSetRepo {
 
   private localStorageOperator: LocalStorageOperator<QuestionSet>
 
-  addQuestionSet(questionSet: QuestionSet): void {
+  upsertQuestionSet(questionSet: QuestionSet): void {
     if (
       this.localStorageOperator.findOneByFilter(
-        (q) => q.name === questionSet.name,
+        (q) => q.name === questionSet.name && q.id !== questionSet.id,
       )
     ) {
-      throw new AddQuestionSetError(
+      throw new UpsertQuestionSetError(
         'DUPLICATE_QUESTION_SET_NAME',
         `QuestionSet with name ${questionSet.name} already exists`,
       )