Refactor into createProductAndGetId

leung018 · Dec 20, 2024 · 55cad05 · 55cad05
1 parent cb4d989
commit 55cad05
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/src/test/java/com/leungcheng/spring_simple_backend/SpringSimpleBackendApplicationTests.java b/src/test/java/com/leungcheng/spring_simple_backend/SpringSimpleBackendApplicationTests.java
@@ -266,12 +266,10 @@ void shouldCreateOrder() throws Exception {
     // Product 1
     productParams.price = "1";
     productParams.quantity = 99;
-    MvcResult result = createProduct(productParams).andReturn();
-    String product1Id = JsonPath.read(result.getResponse().getContentAsString(), "$.id");
+    String product1Id = createProductAndGetId(productParams);
 
     // Product 2
-    result = createProduct(productParams).andReturn();
-    String product2Id = JsonPath.read(result.getResponse().getContentAsString(), "$.id");
+    String product2Id = createProductAndGetId(productParams);
 
     // Create Order
     CreateOrderParams createOrderParams =
@@ -294,8 +292,7 @@ void shouldCreateOrderRejectTooLongRequestId() throws Exception {
     CreateProductParams productParams = CreateProductParams.sample();
     productParams.price = "1";
     productParams.quantity = 99;
-    MvcResult result = createProduct(productParams).andReturn();
-    String productId = JsonPath.read(result.getResponse().getContentAsString(), "$.id");
+    String productId = createProductAndGetId(productParams);
 
     CreateOrderParams createOrderParams =
         new CreateOrderParams("1".repeat(37), ImmutableMap.of(productId, 1));
@@ -308,8 +305,7 @@ void shouldCreateOrderApiHandleExceptionDueToNegativeQuantity() throws Exception
     useNewUserAccessToken();
 
     CreateProductParams productParams = CreateProductParams.sample();
-    MvcResult result = createProduct(productParams).andReturn();
-    String productId = JsonPath.read(result.getResponse().getContentAsString(), "$.id");
+    String productId = createProductAndGetId(productParams);
 
     CreateOrderParams createOrderParams =
         new CreateOrderParams("request-001", ImmutableMap.of(productId, -1));
@@ -325,8 +321,7 @@ void shouldCreateOrderApiHandleCreateOrderExceptionFromOrderService() throws Exc
 
     CreateProductParams productParams = CreateProductParams.sample();
     productParams.quantity = 0;
-    MvcResult result = createProduct(productParams).andReturn();
-    String productId = JsonPath.read(result.getResponse().getContentAsString(), "$.id");
+    String productId = createProductAndGetId(productParams);
 
     CreateOrderParams createOrderParams =
         new CreateOrderParams("request-001", ImmutableMap.of(productId, 1));
@@ -370,6 +365,11 @@ private ResultActions createProduct(CreateProductParams params) throws Exception
     return mockMvc.perform(builder);
   }
 
+  private String createProductAndGetId(CreateProductParams params) throws Exception {
+    MvcResult result = createProduct(params).andReturn();
+    return JsonPath.read(result.getResponse().getContentAsString(), "$.id");
+  }
+
   private ResultActions getProduct(String id) throws Exception {
     MockHttpServletRequestBuilder builder = get("/products/" + id);
     addAuthHeader(builder);