Merge pull request #29 from leung018/product-domain-update

Validate userId in product domain layer
leung018 · Dec 20, 2024 · bbee66f · bbee66f
2 parents 3bdf0a3 + 8e39796
commit bbee66f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/src/main/java/com/leungcheng/spring_simple_backend/domain/Product.java b/src/main/java/com/leungcheng/spring_simple_backend/domain/Product.java
@@ -68,7 +68,7 @@ public Builder toBuilder() {
   @JsonProperty(access = JsonProperty.Access.READ_ONLY)
   private String id;
 
-  private String userId;
+  @NotBlank private String userId;
 
   @NotBlank private String name;
 

diff --git a/src/test/java/com/leungcheng/spring_simple_backend/SpringSimpleBackendApplicationTests.java b/src/test/java/com/leungcheng/spring_simple_backend/SpringSimpleBackendApplicationTests.java
@@ -109,7 +109,7 @@ void shouldIgnoreIdWhenCreateProduct() throws Exception {
   @Test
   void shouldHandleObjectValidationException_AndIncludeTheProperInfoInTheResponse()
       throws Exception {
-    useNewUserAccessToken();
+    String userId = useNewUserAccessToken();
 
     CreateProductParams params = CreateProductParams.sample();
     params.price = "-1";
@@ -120,6 +120,7 @@ void shouldHandleObjectValidationException_AndIncludeTheProperInfoInTheResponse(
       new Product.Builder()
           .name(params.name)
           .price(new BigDecimal(params.price))
+          .userId(userId)
           .quantity(params.quantity)
           .build();
     } catch (ObjectValidationException ex) {

diff --git a/src/test/java/com/leungcheng/spring_simple_backend/domain/ProductTest.java b/src/test/java/com/leungcheng/spring_simple_backend/domain/ProductTest.java
@@ -55,6 +55,9 @@ void shouldRaiseExceptionWhenBuild_IfParamsViolateTheValidationConstraints() {
 
     assertThrowValidationException(productBuilder().name(""));
     assertThrowValidationException(productBuilder().name(null));
+
+    assertThrowValidationException(productBuilder().userId(""));
+    assertThrowValidationException(productBuilder().userId(null));
   }
 
   private void assertThrowValidationException(Product.Builder builder) {