Abstract tests single function #495
Conversation
| const testCommon = require('./common') | ||
| const abstract = require('abstract-leveldown/test/close-test') | ||
|
|
||
| test('setUp', testCommon.setUp) |
There was a problem hiding this comment.
Note that we're skipping setUp and tearDown now.
| const testCommon = require('./common') | ||
| const abstract = require('abstract-leveldown/test/close-test') | ||
|
|
||
| test('setUp', testCommon.setUp) |
There was a problem hiding this comment.
Hmm, we should add a setup+teardown to https://github.com/Level/abstract-leveldown/blob/master/test/close-test.js
There was a problem hiding this comment.
And an .all() method.
There was a problem hiding this comment.
I'll make an issue and hack it up.
| } | ||
|
|
||
| module.exports = testCommon | ||
| module.exports = require('abstract-leveldown/test/common')({ |
|
I'll update this PR once Level/abstract-leveldown#278 has been merged |
|
I get the following error now:
|
|
@ralphtheninja we have to update chained batch. |
I'll look into it. |
|
The C++ takes the first argument as a function, should be the second: Line 135 in 0f5f554 |
|
Hmm I now see that So perhaps we should just remove the |
I think it's fine to pass on options to It's more consistent passing options further. |
|
It'd be dead code though (effectively), unless we also add an options argument to levelup. |
So lets do that :) |
It could default to |
|
Alright, SGTM |
|
@vweevers Make an issue? |
* Target abstract-leveldown#ffba12f * Use single test function from abstract-leveldown * Target abstract-leveldown#d7411bb * Options is actually now passed as options from abstract-leveldown and not a function
* Target abstract-leveldown#ffba12f * Use single test function from abstract-leveldown * Target abstract-leveldown#d7411bb * Options is actually now passed as options from abstract-leveldown and not a function
No description provided.