Additional Outlook Versions, Yahoo Replies, Better support for multi-client reply chains, and Dependency Update

[acterry]

Changes

Selector Changes

• Added support for Outlook 2007/2010 American and Outlook 2013/16/19 American and International
  • changes based on selectors removed from talon when they switched to regexes in this commit
• Made all querySelectorAll queries case-insensitive since I found some lowercased hex color codes in some outlook emails in my data

fixed zero-based array issue in findOutlookSplitterWithQuerySelector code

• this may have undone something that was intentional, since the original outlook-mixed test case didn't have a new message it in., just a forward and some replies
• code would fail detection unless at least two splitters were found and it would leave the first quoted message in the result.
• corrected outlook-mixed test case based on changes. Previously sample message only included a forward and several replies

Added new cut function to handle replies using the yahoo_quoted class

Add support for removing Yahoo replies that use the yahoo_quoted class

Handle reply chains among multiple clients by simply running all cut function

Removing replies from HTML messages is based on executing a list of email client-specific cut functions. Previously the code would stop after the first client-specific cut function found something to remove.

This didn't work well when the message had several replies in it and the cut function only removed a portion of the reply chain.

I'm simply running all of the cut functions -- not stopping after the first hit. This comes with a performance penalty, but still allows each cut function to continue to have freedom of implementation -- instead of forcing them to report back the DOM position and using centralized code to remove signature elements.

Updated all dependencies to latest stable, except for Mocha.

• Stopped Mocha at latest version of 6.x since 7.0 drops Node v6 support and I'm not sure what versions planer needs to support.

I'm running Node 12 LTS on my dev box. I didn't check, but I imagine that some other dependency that I upgraded has likely dropped Node 6 support. Not sure if that's important or not.

[acterry]

@l8on, @eshenfield, @jylauril,

I hope all of you are doing well. Is this project still being maintained?

I've added a few more enhancements in my fork after issuing this PR a few weeks back.

[l8on]

Hey @acterry thanks for the ping.
I will take a look in more detail later this week, but on first glance one blocker would be the upgrade to coffeescript@2.

If you could downgrade the coffeescript back to the latest 1.x.x version, we would happily include your improvements in the published version after a successful Pull Request review.

[acterry]

@l8on,

Thanks for the reply. No problem, I’ll take a look at that downgrade.

I added a few other features to my fork since issuing this PR a few weeks back.

If you’re interested in considering all of these, I can downgrade my form to Coffeescript 1.x.x and update this PR.

• Detect replies using the yahoo_quoted class (Detect replies using the yahoo_quoted class acterry/planer#4)
• Handle reply chains from a mix of clients by running all cut functions (handle reply chains among multiple clients by simply running all cut … acterry/planer#2
• make querySelectorAll selectors case-insensitive since hex color colors are sometimes lowercased by outlook (acterry@6df227d)

[acterry]

Actually, this PR already has all of my subsequent changes in it since the request is to merge my master into your master. When I initially did it, I wasn't planning any more additions.

If you want, I can close this PR and issue a new one from the branch specific to this change.

In the meantime, I'm going to update the description of this PR.

[l8on]

@acterry Don't worry about issuing a new PR, and thank you for updating the description.

To respond to some info in your description:

I'm running Node 12 LTS on my dev box. I didn't check, but I imagine that some other dependency that I upgraded has likely dropped Node 6 support. Not sure if that's important or not.

We need to support Node 8+ with planer.

This comes with a performance penalty, but still allows each cut function to continue to have freedom of implementation -- instead of forcing them to report back the DOM position and using centralized code to remove signature elements.

I am a little concerned about this performance hit, but appreciate the improved completeness of the solution. Given this change in behavior, we may consider a major version bump for these changes such that we don't surprise anyone with bigger email processing bills.

---

Once the coffeescript version is downgraded, I look forward to taking a deeper look and testing it out myself.

[acterry]

@l8on , thanks for the comments.

I'll switch my environment to the latest 8.x Node version, make the necessary changes, and switch to CoffeeScript 1.x.x.

I'll let you know when I'm done. It should be sometime this week.

[acterry]

@l8on , sorry for the huge delay on this one. It’s on my list to resolve.

just want to make sure that Coffeescript 1.x and Node 8 are still the targets.

[l8on]

@acterry Yup, Coffeescript 1.x and Node 8+ are still the targets for this module.

[felixfbecker]

The fixes in this PR would be really awesome to have!

[acterry]

@felixfbecker , thanks for the reminder. It fell off my radar long ago.

However, I still use the code from my fork and it would be nice to have them upstream -- assuming that the maintainers are still interested in them.