Avoid double builds on OSX #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A single file change may trigger multiple events on OSX that are seconds apart, which will then cause multiple builds. This commit tests whether the mtime actually changed.
|
I used @kalafut 's build and it appears to have cleared up the double-build issue. 👍 |
Closed
|
No idea how I missed these -- buried in my inbox, I guess. Sorry for the delay and thank you for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for glitch. It's useful.
I noticed that every file save was generating multiple builds. It's most likely due to double events from OSX + Spotlight (howeyc/fsnotify#62). This commit addresses it by testing whether the file's mtime is different, which it isn't under this double event scenario.
The change also fixes a bug in the buildQueued logic. The variable was simply getting set to the most recent hasSuffix() call, which would fail to trigger a build if a non-Go file was modified last. You can see this with:
touch app.go; touch readme.txt. The buildQueued state should latch to true.