Skip to content

Commit

Permalink
Adding prelint checks in PR gates (microsoft#14566)
Browse files Browse the repository at this point in the history
* adding prelint checks

* fixing publish

* Change files

* fix change files
  • Loading branch information
kenotron authored and levithomason committed Aug 24, 2020
1 parent 439812c commit 27aba3e
Show file tree
Hide file tree
Showing 67 changed files with 282 additions and 69 deletions.
2 changes: 1 addition & 1 deletion apps/a11y-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"axe-sarif-converter": "^2.0.1",
"glob": "^7.1.2",
"mkdirp": "^0.5.1",
"office-ui-fabric-react": "^7.128.1",
"office-ui-fabric-react": "^7.128.2",
"puppeteer": "^1.13.0",
"tslib": "^1.10.0",
"react": "16.8.6",
Expand Down
2 changes: 1 addition & 1 deletion apps/dom-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"jest-environment-node": "~24.9.0",
"jest-environment-puppeteer": "^4.1.0",
"jest-puppeteer": "^4.0.0",
"office-ui-fabric-react": "^7.128.1",
"office-ui-fabric-react": "^7.128.2",
"puppeteer": "^1.13.0",
"react-dom": "16.8.6",
"react": "16.8.6",
Expand Down
10 changes: 5 additions & 5 deletions apps/fabric-website-resources/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,21 +38,21 @@
"dependencies": {
"@microsoft/load-themed-styles": "^1.10.26",
"@uifabric/api-docs": "^7.3.39",
"@uifabric/azure-themes": "^7.3.4",
"@uifabric/azure-themes": "^7.3.5",
"@uifabric/example-app-base": "^7.12.113",
"@uifabric/fluent-theme": "^7.1.130",
"@uifabric/fluent-theme": "^7.1.131",
"@uifabric/icons": "^7.3.73",
"@uifabric/mdl2-theme": "^0.1.131",
"@uifabric/merge-styles": "^7.16.6",
"@uifabric/react-cards": "^0.110.23",
"@uifabric/set-version": "^7.0.21",
"@uifabric/styling": "^7.14.13",
"@uifabric/theme-samples": "^7.0.125",
"@uifabric/tsx-editor": "^0.11.129",
"@uifabric/tsx-editor": "^0.11.130",
"@uifabric/utilities": "^7.28.0",
"@uifabric/variants": "^7.1.115",
"@uifabric/variants": "^7.1.116",
"office-ui-fabric-core": "^11.0.0",
"office-ui-fabric-react": "^7.128.1",
"office-ui-fabric-react": "^7.128.2",
"tslib": "^1.10.0"
},
"peerDependencies": {
Expand Down
6 changes: 3 additions & 3 deletions apps/fabric-website/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"@types/react-dom": "16.8.4",
"@types/webpack-env": "1.15.1",
"@uifabric/build": "^7.0.0",
"@uifabric/tsx-editor": "^0.11.129",
"@uifabric/tsx-editor": "^0.11.130",
"react": "16.8.6",
"react-app-polyfill": "~1.0.1",
"react-dom": "16.8.6",
Expand All @@ -46,14 +46,14 @@
"@uifabric/experiments": "^7.28.2",
"@uifabric/fabric-website-resources": "^7.6.121",
"@uifabric/file-type-icons": "^7.4.14",
"@uifabric/fluent-theme": "^7.1.130",
"@uifabric/fluent-theme": "^7.1.131",
"@uifabric/icons": "^7.3.73",
"@uifabric/react-cards": "^0.110.23",
"@uifabric/set-version": "^7.0.21",
"@uifabric/theme-samples": "^7.0.125",
"json-loader": "^0.5.7",
"office-ui-fabric-core": "^11.0.0",
"office-ui-fabric-react": "^7.128.1",
"office-ui-fabric-react": "^7.128.2",
"tslib": "^1.10.0",
"whatwg-fetch": "2.0.4"
},
Expand Down
2 changes: 1 addition & 1 deletion apps/perf-test/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"@uifabric/example-app-base": "^7.12.113",
"@uifabric/experiments": "^7.28.2",
"@microsoft/load-themed-styles": "^1.10.26",
"office-ui-fabric-react": "^7.128.1",
"office-ui-fabric-react": "^7.128.2",
"querystring": "^0.2.0",
"react": "16.8.6",
"react-app-polyfill": "~1.0.1",
Expand Down
2 changes: 1 addition & 1 deletion apps/server-rendered-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"@uifabric/icons": "^7.3.73",
"@uifabric/merge-styles": "^7.16.6",
"@uifabric/set-version": "^7.0.21",
"office-ui-fabric-react": "^7.128.1",
"office-ui-fabric-react": "^7.128.2",
"react": "16.8.6",
"react-app-polyfill": "~1.0.1",
"react-dom": "16.8.6",
Expand Down
2 changes: 1 addition & 1 deletion apps/ssr-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"@uifabric/fabric-website-resources": "^7.6.121",
"just-scripts-utils": "^0.8.3",
"mocha": "^3.3.0",
"office-ui-fabric-react": "^7.128.1",
"office-ui-fabric-react": "^7.128.2",
"raw-loader": "^0.5.1",
"react": "16.8.6",
"react-app-polyfill": "~1.0.1",
Expand Down
4 changes: 2 additions & 2 deletions apps/test-bundles/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@
"dependencies": {
"@fluentui/keyboard-key": "^0.2.10",
"@fluentui/react-button": "^0.9.3",
"@fluentui/react-compose": "^0.14.5",
"@fluentui/react-compose": "^0.15.0",
"@fluentui/react-next": "^8.0.0-alpha.86",
"@uifabric/experiments": "^7.28.2",
"@uifabric/set-version": "^7.0.21",
"@uifabric/styling": "^7.14.13",
"office-ui-fabric-react": "^7.128.1",
"office-ui-fabric-react": "^7.128.2",
"react": "16.8.6",
"react-app-polyfill": "~1.0.1",
"react-dom": "16.8.6",
Expand Down
4 changes: 2 additions & 2 deletions apps/theming-designer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@
"@uifabric/react-cards": "^0.110.23",
"@uifabric/merge-styles": "^7.16.6",
"@uifabric/example-app-base": "^7.12.113",
"@uifabric/variants": "^7.1.115",
"@uifabric/variants": "^7.1.116",
"@uifabric/set-version": "^7.0.21",
"@uifabric/icons": "^7.3.73",
"@microsoft/load-themed-styles": "^1.10.26",
"office-ui-fabric-react": "^7.128.1",
"office-ui-fabric-react": "^7.128.2",
"react": "16.8.6",
"react-app-polyfill": "~1.0.1",
"react-dom": "16.8.6",
Expand Down
2 changes: 1 addition & 1 deletion apps/todo-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"@microsoft/load-themed-styles": "^1.10.26",
"es6-promise": "^4.1.0",
"immutability-helper": "~2.8.1",
"office-ui-fabric-react": "^7.128.1",
"office-ui-fabric-react": "^7.128.2",
"react": "16.8.6",
"react-app-polyfill": "~1.0.1",
"react-dom": "16.8.6",
Expand Down
2 changes: 1 addition & 1 deletion apps/vr-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"@uifabric/react-cards": "^0.110.23",
"@uifabric/react-hooks": "^7.8.2",
"@uifabric/set-version": "^7.0.21",
"office-ui-fabric-react": "^7.128.1",
"office-ui-fabric-react": "^7.128.2",
"react": "16.8.6",
"react-app-polyfill": "~1.0.1",
"react-dom": "16.8.6",
Expand Down
5 changes: 5 additions & 0 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ jobs:
yarn checkchange
displayName: check change
## manually call this since lage is now used and it calls lint per package, not per repo
- script: |
yarn prelint
displayName: do syncpack and no-tslint checks
## only do scoped builds with PRs
- script: |
yarn lage build test lint --verbose --no-cache --grouped --since $(target_branch)
Expand Down
8 changes: 8 additions & 0 deletions change/@fluentui-codemods-2020-08-17-18-44-47-prelint.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "fixing publish",
"packageName": "@fluentui/codemods",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-08-18T01:43:23.107Z"
}
8 changes: 8 additions & 0 deletions change/@fluentui-examples-2020-08-17-18-44-47-prelint.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "fixing publish",
"packageName": "@fluentui/examples",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-08-18T01:43:31.753Z"
}
8 changes: 8 additions & 0 deletions change/@fluentui-react-2020-08-17-18-44-47-prelint.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "fixing publish",
"packageName": "@fluentui/react",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-08-18T01:44:38.658Z"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "fixing publish",
"packageName": "@fluentui/react-avatar",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-08-18T01:43:44.953Z"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "fixing publish",
"packageName": "@fluentui/react-button",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-08-18T01:43:46.505Z"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "fixing publish",
"packageName": "@fluentui/react-compose",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-08-18T01:43:49.745Z"
}
8 changes: 8 additions & 0 deletions change/@fluentui-react-image-2020-08-17-18-44-47-prelint.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "fixing publish",
"packageName": "@fluentui/react-image",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-08-18T01:43:52.146Z"
}
8 changes: 8 additions & 0 deletions change/@fluentui-react-next-2020-08-17-18-44-47-prelint.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "prerelease",
"comment": "fix publishing by syncing packages (#12715)",
"packageName": "@fluentui/react-next",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-08-18T01:44:31.717Z"
}
8 changes: 8 additions & 0 deletions change/@fluentui-react-tabs-2020-08-17-18-44-47-prelint.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "fix publishing by syncing packages (#12715)",
"packageName": "@fluentui/react-tabs",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-08-18T01:44:36.828Z"
}
8 changes: 8 additions & 0 deletions change/@fluentui-storybook-2020-08-17-18-44-47-prelint.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "fixing publish",
"packageName": "@fluentui/storybook",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-08-18T01:44:40.315Z"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "fixing publish",
"packageName": "@fluentui/web-components",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-08-18T01:44:47.258Z"
}
8 changes: 8 additions & 0 deletions change/@uifabric-api-docs-2020-08-17-18-44-47-prelint.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "fixing publish",
"packageName": "@uifabric/api-docs",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-08-18T01:43:06.490Z"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "fix publish",
"packageName": "@uifabric/azure-themes",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-08-18T01:43:10.482Z"
}
8 changes: 8 additions & 0 deletions change/@uifabric-charting-2020-08-17-18-44-47-prelint.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "fix publish",
"packageName": "@uifabric/charting",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-08-18T01:43:16.456Z"
}
8 changes: 8 additions & 0 deletions change/@uifabric-date-time-2020-08-17-18-44-47-prelint.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "fixing publish",
"packageName": "@uifabric/date-time",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-08-18T01:43:25.042Z"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "fixing publish",
"packageName": "@uifabric/example-app-base",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-08-18T01:43:29.897Z"
}
8 changes: 8 additions & 0 deletions change/@uifabric-experiments-2020-08-17-18-44-47-prelint.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "fixing publish",
"packageName": "@uifabric/experiments",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-08-18T01:43:33.306Z"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "Update web components to use latest version of fast-element (#14573)",
"packageName": "@uifabric/fabric-website",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-08-18T01:43:02.681Z"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "fixing publish",
"packageName": "@uifabric/fabric-website-resources",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-08-18T01:43:01.540Z"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "fixing publish",
"packageName": "@uifabric/fluent-theme",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-08-18T01:43:38.970Z"
}
8 changes: 8 additions & 0 deletions change/@uifabric-mdl2-theme-2020-08-17-18-44-47-prelint.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "fixing publish",
"packageName": "@uifabric/mdl2-theme",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-08-18T01:43:40.563Z"
}
8 changes: 8 additions & 0 deletions change/@uifabric-react-cards-2020-08-17-18-44-47-prelint.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "fixing publish",
"packageName": "@uifabric/react-cards",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-08-18T01:43:48.138Z"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "fixing publish",
"packageName": "@uifabric/theme-samples",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-08-18T01:44:42.267Z"
}
8 changes: 8 additions & 0 deletions change/@uifabric-tsx-editor-2020-08-17-18-44-47-prelint.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "fixing publish",
"packageName": "@uifabric/tsx-editor",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-08-18T01:44:43.953Z"
}
8 changes: 8 additions & 0 deletions change/@uifabric-variants-2020-08-17-18-44-47-prelint.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "fixing publish",
"packageName": "@uifabric/variants",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-08-18T01:44:45.570Z"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "fixing publish",
"packageName": "office-ui-fabric-react",
"email": "kchau@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-08-18T01:43:42.139Z"
}
2 changes: 1 addition & 1 deletion packages/api-docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"@uifabric/react-cards": "^0.110.23",
"@uifabric/styling": "^7.14.13",
"@uifabric/utilities": "^7.28.0",
"office-ui-fabric-react": "^7.128.1"
"office-ui-fabric-react": "^7.128.2"
},
"dependencies": {
"@microsoft/api-extractor-model": "7.7.1",
Expand Down
Loading

0 comments on commit 27aba3e

Please sign in to comment.