Cria arquivo de scripts separado #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….liquid Signed-off-by: George Araújo <george.gcac@gmail.com>
Signed-off-by: George Araújo <george.gcac@gmail.com>
✅ Deploy Preview for diciotech ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: George Araújo <george.gcac@gmail.com>
Signed-off-by: George Araújo <george.gcac@gmail.com>
|
PS: ignora o sort data files e o prettier nessa PR, preferi não mexer nisso agora e resolver tudo na do prettier. |
There was a problem hiding this comment.
Copilot reviewed 6 out of 12 changed files in this pull request and generated no comments.
Files not reviewed (6)
- _includes/script.js.liquid: Language not supported
- _json/en-us/cards.json.liquid: Language not supported
- _json/pt-br/cards.json.liquid: Language not supported
- _layouts/base.liquid: Language not supported
- _scripts/scripts.js.liquid: Language not supported
- _pages/en-us/search.md: Evaluated as low risk
levxyca
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descrição de PR
Cria o arquivo de script que lida com os cards num arquivo próprio:
Antes:
Depois:
Issue relacionado
Motivações
Não só pro HTML ficar mais bonito, mas com o js não estando inline o
jekyll-minifierconsegue minificar também esse arquivo js.Informações adicionais
Eu tive que fazer mais algumas mudanças, como mover todas as strings traduzidas que fazem parte da UI do site (e não dos cards) de
_pages/LANG/search.mdpra_data/LANG/strings.ymlpra poder isso funcionar devidamente.