-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added feature to ignore checks fixed #38 #80
Conversation
4f91e85
to
df56dec
Compare
@matiasalbarello can chance to review this and getting merged ? |
7421a35
to
60446b9
Compare
3792837
to
09e595c
Compare
@matiasalbarello do you feel that this is useful and working okay? |
@@ -47,6 +48,8 @@ def log_checks(checks, msg) | |||
|
|||
def apply_filters(checks) | |||
checks.reject! { |check| check.name == workflow_name } | |||
checks.reject! { |check| ignore_checks.include?(check.name) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to avoid iterating the array twice (by calling reject
), I'd suggest joining both of them:
checks.reject! { |check| [ignore_checks, workflow_name].flatten.include?(check.name) }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Done !
thanks for the PR! I think that overall it looks ok. I left a few comments :) |
@omkarkhatavkar, it seems that a test got broken. Could you fix it? |
371d6d9
to
0f57c52
Compare
@matiasalbarello it's hard for me to debug the ruby code, not know much about the stuff, I do fix the issue can you please cross-check? |
This PR will add the feature requested for #38