Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom border is missing when the commit message is too long #841

Closed
rockyzhang24 opened this issue Jul 18, 2023 · 4 comments · Fixed by #842
Closed

Bottom border is missing when the commit message is too long #841

rockyzhang24 opened this issue Jul 18, 2023 · 4 comments · Fixed by #842
Labels
bug Something isn't working

Comments

@rockyzhang24
Copy link
Contributor

Description

First enable the border for preview window

require('gitsigns').setup {
  preview_config = {
    border = 'single',
  },
}

Then open an arbitrary file and run :lua require('gitsigns').blame_line({ full = true }) on a certain line with a long enough (longer than the screen height) commit message. The bottom border of the floating window is missing.

Screenshot 2023-07-17 at 19 48 53

(Just FYI: the file I was using in the pic is https://github.com/junegunn/fzf/blob/master/src/core.go)

Neovim version

NVIM v0.10.0-dev-551+ge27377e33

Operating system and version

macOS 13.4.1

Expected behavior

The bottom border should be shown as normal

Actual behavior

The bottom border of the floating window is missing

Minimal config

require('gitsigns').setup {
  preview_config = {
    border = 'single',
  },
}

Steps to reproduce

See the "Description" section above please.

Gitsigns debug messages

No response

@rockyzhang24 rockyzhang24 added the bug Something isn't working label Jul 18, 2023
@lewis6991
Copy link
Owner

Is this really a problem?

@rockyzhang24
Copy link
Contributor Author

rockyzhang24 commented Jul 18, 2023

Not exactly, but just want to make gitsigns as perfect as possible. Please forgive my perfectionism.

@lewis6991
Copy link
Owner

I'll accept a PR, but this isn't something I'll have time to fix.

@lewis6991 lewis6991 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 18, 2023
@rockyzhang24
Copy link
Contributor Author

Already opened a PR to fix this. Thank you.

lewis6991 pushed a commit that referenced this issue Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants