Added curhl to change the cursorline highlight for signs

[c0r73x]

Adds curhl to signs, fixes #563

[lewis6991]

Needs to be added and documented in the config and added properly to the type annotations.

Also need to define and document default highlight groups for this.

[c0r73x]

I added it to the default config, though i think it's kinda pointless since it will always default to the sign highlight unless specified. 🤷‍♂️

[lewis6991]

Why does that make it pointless?

[c0r73x]

Since if it's not specified it will work as it did before, and If it's specified it will change the cursor highlight to the specified group. So the default config could just as well exclude the curhl value and nothing would change.

[lewis6991]

I don't think you understand.

[lewis6991]

This needs its own unique highlight group which is cleared by default. Highlight groups are managed in highlights.lua.

Then you need to run make to update the documentation.

[c0r73x]

Why?

Everything is handled by neovim internally in nvim_buf_set_extmark, that's why i think it's pointless to add a default for it, if cursorline_hl_group is not specified it will use the default highlight specified for the extmark (like it was before this change). If it's specified it will use that group.

                  • cursorline_hl_group: name of the highlight group used to
                    highlight the sign column text when the cursor is on the
                    same line as the mark and 'cursorline' is enabled.

[lewis6991]

extmarks are an implementation choice. They have nothing to do with the API gitsigns exposes. All highlights that Gitsigns uses are defined and documented. Eventually I'm going to remove these from the configuration in setup().

Any I wasted enough time on this so closing.