fix(watcher): do not ignore any updates #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewis6991
force-pushed
the
fix/watcher_ignore
branch
from
7808cfe
to
850d9cd
Compare
Now the watcher handlers is debounced and throttled, the ignore list is no longer necessary. This avoids an issue where we sometimes trigger the handler too early (as other files are still changing). Now the debounce and throttle logic and take into account every single file change.
lewis6991
force-pushed
the
fix/watcher_ignore
branch
from
850d9cd
to
2318bad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the watcher handlers is debounced and throttled, the ignore list
is no longer necessary.
This avoids an issue where we sometimes trigger the handler too early
(as other files are still changing). Now the debounce and throttle logic
and take into account every single file change.