fix(repeat): support remapped l key
#653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I use a non-qwerty layout and so `hjkl` keys are not close to home row, but instead scattered around the keyboard. Consequently, I remap `l` to something more convenient. Recently (it turns out, after commit 9787c94), commands like `Gitsigns stage_hunk` stopped working, i.e. calling them would not stage the given hook. The problem is that `mk_repeatable` assumes a default mapping on `l` when it calls `normal g@l`. Calling `normal!` fixes this, because then custom mappings are disregarded and `normal g@l` calls the `stage_hunk` or whatever was made repeatable. I believe this should fix lewis6991#651, although I did not test that.
|
Awesome. Thanks! |
|
Thanks for the quick turn-around and for making this awesome plugin! |
|
@lewis6991 Would you mind adding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use a non-qwerty layout and so
hjklkeys are not close to home row,but instead scattered around the keyboard. Consequently, I remap
ltosomething more convenient.
Recently (it turns out, after commit
9787c94), commands like
Gitsigns stage_hunkstopped working, i.e. calling them would not stage the givenhook.
The problem is that
mk_repeatableassumes a default mapping onlwhen it calls
normal g@l. Callingnormal!fixes this, because thencustom mappings are disregarded and
normal g@lcalls thestage_hunkor whatever was made repeatable.
I believe this should fix #651, although I did not test that.