fix(cli): named args not working #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
:Gitsigns next_hunk,:Gitsigns prev_hunkand:Gitsigns blame_line, named arguments aren't working. For example,:Gitsigns blame_line full=truedoes not display the "full" blame popup, and behaves identically to:Gitsigns blame_line.I've just added three wrapper functions to the
Ctable, which seems to solve the issue for me. From what I can tell, the logic inlua/gitsigns/cli.lua:106dealing with named arguments isn't needed, since all of the the functions ingitsigns.actionsthat use named arguments (ie a table) now have wrappers inC- but I haven't changed anything there because I'm not confident it won't break anything :)