fix: error message when :Gitsigns select dialog is cancelled
#915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theofabilous
force-pushed
the
silent-cancel
branch
from
00e3d28
to
35a45c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
:Gitsignscommand prompts the user for an action viavim.ui.selectwhen called without arguments, which yieldsnilwhen the dialog is cancelled.Currently, this is not checked and if the user cancels the dialog, an error message is displayed: 'nil is not a valid function or action'. This PR simply returns from
cli.run()silently if thevim.ui.selectprompt was cancelled.