Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix: assert because M.version is nil #960

Closed
wants to merge 1 commit into from
Closed

bug fix: assert because M.version is nil #960

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion lua/gitsigns/git.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ end
--- @return boolean
local function check_version(version)
if not M.version then
return false
M._set_version(config._git_version)
return check_version(version)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this line is necessary. Once the version is set the rest of the function should work.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plugin functions properly once the M.version is loaded. However, the persistent assert messages that appear every time files are loaded are bothersome. I would appreciate it if the assert statement in get_repo_info could be eliminated.

end
if M.version.major < version[1] then
return false
Expand Down