-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ctrl+Z shortcut keeps executing browser's functionality instead of prevent it. #189
Comments
Trung0246
changed the title
Ctrl+Z shortcut keep executing browser's functionality instead of prevent it.
Ctrl+Z shortcut keeps executing browser's functionality instead of prevent it.
Apr 29, 2021
This is something I see locally on vivaldi too. |
iamakulov
added a commit
to iamakulov/asciiflow
that referenced
this issue
Jun 10, 2024
This commit calls `preventDefault()` for a few keyboard shortcuts. Partially addresses lewish#189
Also stumbled upon this. On macOS, in Arc, Cmd+Z reopens the closed tab (unless Likewise, Cmd+Y opens browsing history in all macOS browsers, which also conflicts with “redo” here. Raised a PR to address this: #301 |
lewish
pushed a commit
that referenced
this issue
Jun 12, 2024
This commit calls `preventDefault()` for a few keyboard shortcuts. Partially addresses #189
lewish
pushed a commit
that referenced
this issue
Aug 6, 2024
This commit calls `preventDefault()` for a few keyboard shortcuts. Partially addresses #189
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Apparently asciiflow didn't call
preventDefault
to stop default browser behaviour on Ctrl+Z. Looking at the code seems likepreventDefault
only appear at touch input. I would suggest to addpreventDefault
on keyboard input too, especially with shortcut like Ctrl+Z which is a common shortcut on different browsers.Browser: Vivaldi. OS: Win10.
The text was updated successfully, but these errors were encountered: