Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lewisxhe:
https_post_file
leads to a compiler warning. After close inspection, I am wondering if it is correctly written... There is no bound check and a comparison with a reference of a - maybe - character ?So he is a proposed implementation which seems more correct to me and also fixes the warning.
Same as other PR, the first commit includes #4 (CI) in order to get build feedback (which can be seen in my fork: https://github.com/mathieucarbou/lewisxhe-TinyGSM/actions).
The commit relevant to this PR is the second one.