Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A76xx: Rewrote https_post_file #6

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

mathieucarbou
Copy link

@mathieucarbou mathieucarbou commented Mar 17, 2024

@lewisxhe: https_post_file leads to a compiler warning. After close inspection, I am wondering if it is correctly written... There is no bound check and a comparison with a reference of a - maybe - character ?

So he is a proposed implementation which seems more correct to me and also fixes the warning.

In file included from src/TinyGsmClientA7670.h:30,
                 from src/TinyGsmClient.h:66,
                 from /Users/mat/Data/Workspace/forks/TinyGSM/tools/test_build/test_build.ino:7:
src/TinyGsmHttpsA76xx.h: In member function 'int TinyGsmHttpsA76xx<modemType>::https_post_file(const char*, uint8_t, bool)':
src/TinyGsmHttpsA76xx.h:291:26: warning: comparing the result of pointer addition '(filepath + 3)' and NULL [-Waddress]
  291 |         if (&filepath[3] == NULL)return -1;
      |                          ^

Same as other PR, the first commit includes #4 (CI) in order to get build feedback (which can be seen in my fork: https://github.com/mathieucarbou/lewisxhe-TinyGSM/actions).

The commit relevant to this PR is the second one.

- Add workflow_dispatch
- Fix test which was breaking CI
- Update CI plugins
- Only run CI with esp32dev and esp32s3box (only for Lily boards)
- Declared library to only be compatible with esp32
@lewisxhe lewisxhe merged commit b3ee8dc into lewisxhe:master Mar 18, 2024
@mathieucarbou mathieucarbou deleted the pr/A76xx branch March 18, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants