fix: try fail fast approach

lewxdev · Aug 27, 2024 · 53a39df · 53a39df
1 parent 1653933
commit 53a39df
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/.env.sample b/.env.sample
@@ -1,3 +1,5 @@
+BASE_URL=http://localhost:3000
+
 # redis
 REDIS_PASSWORD=
 REDIS_URL=redis://default:$REDIS_PASSWORD@localhost:16379
diff --git a/.github/workflows/fly-review.yml b/.github/workflows/fly-review.yml
@@ -30,6 +30,7 @@ jobs:
       - id: deploy
         uses: superfly/fly-pr-review-apps@1.2.1
         with:
+          name: ${{ env.FLY_APP_NAME }}
           secrets: |
             BASE_URL=https://${{ env.FLY_APP_NAME }}.fly.dev
             REDIS_URL=${{ secrets.REDIS_URL }}
diff --git a/app/layout.tsx b/app/layout.tsx
@@ -7,7 +7,6 @@ import "@/globals.css";
 
 const title = "mmmines!";
 const description = "an endless, massive multiplayer minesweeper game";
-const baseUrl = process.env["BASE_URL"];
 
 export const metadata: Metadata = {
   title,
@@ -18,7 +17,7 @@ export const metadata: Metadata = {
       { url: "/icon-dark.svg", media: "(prefers-color-scheme: dark)" },
     ],
   },
-  metadataBase: baseUrl ? new URL(baseUrl) : null,
+  metadataBase: new URL(process.env["BASE_URL"]!),
   openGraph: {
     title,
     description,