Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RMIZ workaround #1

Merged
merged 2 commits into from
Aug 21, 2022
Merged

Add RMIZ workaround #1

merged 2 commits into from
Aug 21, 2022

Conversation

rpearce
Copy link
Contributor

@rpearce rpearce commented Aug 20, 2022

This is the fix mentioned in rpearce/react-medium-image-zoom#347 applied to your example.

@rpearce
Copy link
Contributor Author

rpearce commented Aug 20, 2022

While this works for gatsby develop, it's looking like this doesn't work after gatsby build because the onLoad isn't getting fired :(

I'll keep trying in the next couple of nights.

@rpearce
Copy link
Contributor Author

rpearce commented Aug 21, 2022

@lezan Got it! Check out my changes here. Basically, give react-medium-image-zoom@5.0.2-beta.0 a try, and let me know how it goes here: rpearce/react-medium-image-zoom#347

@lezan lezan merged commit 0616471 into lezan:master Aug 21, 2022
@lezan
Copy link
Owner

lezan commented Aug 21, 2022

Hello @rpearce, thanks for your effort (so quickly)! Going to test it out to give you a feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants