Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configuration of the basic docker image #330

Merged

Conversation

tdrozdovsky
Copy link
Contributor

@tdrozdovsky tdrozdovsky commented Jul 9, 2021

Signed-off-by: Taras Drozdovskyi t.drozdovsky@samsung.com

Description

Due to the lack of flexibility to use the basic image of the Doker container and its settings, I added the ability to configure it. Now users can use their docker file and settings in it. Also, after the adoption of this PR, we can contact Vitalii55 so that he adds his version to use the Alpine 3.7 image on x86_64.

P.S. I tested his Alpine 3.7 image and it works well, it should be noted that the size of the image is about 45Mb. This option will be available after applying the PR from Vitalii55

Type of change

  • New feature (non-breaking change which adds functionality)
  • Code cleanup/refactoring

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Below is just an example and you can delete it when you contribute.

$ make distclean
$ make create_context CONFIGFILE=x86_64c
$ make 
$ make run

Test Configuration:

  • Firmware version: (OS type and version, e.g., Ubuntu 18.04, etc.)
  • Hardware: x86-64
  • Toolchain: Recommended Docker and Go version.
  • Edge Orchestration Release: Coconut

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@tdrozdovsky tdrozdovsky added enhancement New feature or request refactoring Any tasks and issues w.r.t. the code refactoring labels Jul 9, 2021
@tdrozdovsky tdrozdovsky self-assigned this Jul 9, 2021
Copy link
Contributor

@tiokim tiokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.
Please take a look at my comments!

Kconfig Outdated Show resolved Hide resolved
Kconfig Outdated Show resolved Hide resolved
Signed-off-by: Taras Drozdovskyi <t.drozdovsky@samsung.com>
@tdrozdovsky tdrozdovsky force-pushed the add-support-diff-docker-images branch from 081b863 to da467e2 Compare July 12, 2021 10:12
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@tdrozdovsky tdrozdovsky requested a review from tiokim July 12, 2021 10:13
Copy link
Contributor

@tiokim tiokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Contributor

@MoonkiHong MoonkiHong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1! 😄

@tdrozdovsky
Copy link
Contributor Author

tdrozdovsky commented Jul 12, 2021

+1! 😄

Thank you! When PR will be accepted, I will contact Vitalii55 to add its code for support of alpine image

@tiokim
Copy link
Contributor

tiokim commented Jul 12, 2021

Thank you! When PR will be accepted, I will contact Vitalii55 to add its code for alpine image

When it comes to Vitalii55's Dockerfile, does it build images in terms of arm and arm64?

@tdrozdovsky
Copy link
Contributor Author

Thank you! When PR will be accepted, I will contact Vitalii55 to add its code for alpine image

When it comes to Vitalii55's Dockerfile, does it build images in terms of arm and arm64?

I tested only x86_64 and Vitalii55 too. But I can check, and I will say the result. In any case, I think that it is necessary to accept code from an external developer, and then fix for arm if it does not work under arm

@tdrozdovsky
Copy link
Contributor Author

@t25kim I successfully compiled the alpine 3.12 image on Ubuntu 18.04 for arm and arm64, but haven't launched yet on board

@MoonkiHong
Copy link
Contributor

@suresh-lc PTAL. 😄

Copy link
Contributor

@suresh-lc suresh-lc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MoonkiHong MoonkiHong merged commit dcf250e into lf-edge:master Jul 15, 2021
@tdrozdovsky tdrozdovsky deleted the add-support-diff-docker-images branch July 26, 2021 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring Any tasks and issues w.r.t. the code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants