-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added configuration of the basic docker image #330
Added configuration of the basic docker image #330
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
Please take a look at my comments!
Signed-off-by: Taras Drozdovskyi <t.drozdovsky@samsung.com>
081b863
to
da467e2
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1! 😄
Thank you! When PR will be accepted, I will contact Vitalii55 to add its code for support of alpine image |
When it comes to Vitalii55's Dockerfile, does it build images in terms of arm and arm64? |
I tested only x86_64 and Vitalii55 too. But I can check, and I will say the result. In any case, I think that it is necessary to accept code from an external developer, and then fix for arm if it does not work under arm |
@t25kim I successfully compiled the alpine 3.12 image on Ubuntu 18.04 for |
@suresh-lc PTAL. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Taras Drozdovskyi t.drozdovsky@samsung.com
Description
Due to the lack of flexibility to use the basic image of the Doker container and its settings, I added the ability to configure it. Now users can use their docker file and settings in it. Also, after the adoption of this PR, we can contact Vitalii55 so that he adds his version to use the Alpine 3.7 image on x86_64.
P.S. I tested his Alpine 3.7 image and it works well, it should be noted that the size of the image is about 45Mb. This option will be available after applying the PR from Vitalii55
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Below is just an example and you can delete it when you contribute.
Test Configuration:
Checklist: