Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace password when create rule #2736

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Mar 26, 2024

No description provided.

Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer Yisaer requested a review from ngjaying March 26, 2024 06:47
@Yisaer Yisaer changed the title fix: replace password when create rule with hidden value fix: replace password when create rule Mar 26, 2024
Signed-off-by: yisaer <disxiaofei@163.com>
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 63.53%. Comparing base (ffef5c6) to head (ba48b8c).

Files Patch % Lines
internal/conf/yaml_config_ops.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2736      +/-   ##
==========================================
+ Coverage   63.50%   63.53%   +0.03%     
==========================================
  Files         339      339              
  Lines       38974    38993      +19     
==========================================
+ Hits        24750    24774      +24     
+ Misses      12059    12053       -6     
- Partials     2165     2166       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yisaer Yisaer marked this pull request as ready for review March 26, 2024 09:20
@ngjaying ngjaying merged commit e6f222a into lf-edge:master Mar 27, 2024
59 checks passed
ngjaying pushed a commit to ngjaying/kuiper that referenced this pull request Mar 29, 2024
Signed-off-by: yisaer <disxiaofei@163.com>
ngjaying pushed a commit that referenced this pull request Mar 29, 2024
Signed-off-by: yisaer <disxiaofei@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants