Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate schema layer from decoder #2815

Merged
merged 2 commits into from
Apr 28, 2024

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Apr 26, 2024

No description provided.

Signed-off-by: yisaer <disxiaofei@163.com>
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 87.20930% with 11 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (master-v2@6ffc019). Click here to learn what that means.

❗ Current head bb5fde4 differs from pull request most recent head 07c0856. Consider uploading reports for the commit 07c0856 to get more accurate results

Files Patch % Lines
internal/converter/schema/schema.go 91.43% 4 Missing and 2 partials ⚠️
internal/topo/node/decode_op.go 55.56% 0 Missing and 4 partials ⚠️
internal/converter/json/converter.go 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master-v2    #2815   +/-   ##
============================================
  Coverage             ?   65.54%           
============================================
  Files                ?      275           
  Lines                ?    30081           
  Branches             ?        0           
============================================
  Hits                 ?    19715           
  Misses               ?     8782           
  Partials             ?     1584           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying merged commit 9b4728c into lf-edge:master-v2 Apr 28, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants