fix: validate sink conf #2949
Merged
fix: validate sink conf #2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2949 +/- ##
==========================================
- Coverage 65.33% 65.33% -0.00%
==========================================
Files 354 354
Lines 34822 34822
==========================================
- Hits 22749 22748 -1
- Misses 9825 9828 +3
+ Partials 2248 2246 -2 ☔ View full report in Codecov by Sentry. |
ngjaying
approved these changes
Jun 26, 2024
ngjaying
pushed a commit
to ngjaying/kuiper
that referenced
this pull request
Jun 27, 2024
Signed-off-by: Song Gao <disxiaofei@163.com>
ngjaying
pushed a commit
to ngjaying/kuiper
that referenced
this pull request
Jun 27, 2024
Signed-off-by: Song Gao <disxiaofei@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.