refactor(converter): add ext props #2958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ngjaying
commented
Jun 27, 2024
ngjaying
commented
- In planner, unify all props and avoid using stream options everywhere
- In converter provider, only provide schemaId and schema. Other extended properties are passed by props
ngjaying
force-pushed
the
v2planner
branch
3 times, most recently
from
0191e1c
to
296fc8a
Compare
- In planner, unify all props and avoid using stream options everywhere - In converter provider, only provide schemaId and schema. Other extended properties are passed by props Signed-off-by: Jiyong Huang <huangjy@emqx.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master-v2 #2958 +/- ##
============================================
Coverage ? 69.74%
============================================
Files ? 310
Lines ? 29710
Branches ? 0
============================================
Hits ? 20720
Misses ? 7191
Partials ? 1799 ☔ View full report in Codecov by Sentry. |
Yisaer
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.