Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support rest sink #2966

Merged
merged 6 commits into from
Jul 2, 2024
Merged

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Jul 1, 2024

No description provided.

Signed-off-by: Song Gao <disxiaofei@163.com>
@Yisaer Yisaer requested a review from ngjaying July 1, 2024 04:13
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 61.36364% with 34 lines in your changes missing coverage. Please review.

Please upload report for BASE (master-v2@1bc9843). Learn more about missing BASE report.

Files Patch % Lines
internal/io/http/rest_sink.go 61.33% 23 Missing and 6 partials ⚠️
pkg/errorx/errors.go 42.86% 4 Missing ⚠️
internal/binder/io/builtin.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master-v2    #2966   +/-   ##
============================================
  Coverage             ?   69.46%           
============================================
  Files                ?      320           
  Lines                ?    30543           
  Branches             ?        0           
============================================
  Hits                 ?    21214           
  Misses               ?     7460           
  Partials             ?     1869           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Song Gao <disxiaofei@163.com>
internal/io/http/rest_sink.go Outdated Show resolved Hide resolved
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
@Yisaer Yisaer requested a review from ngjaying July 1, 2024 07:45
@ngjaying ngjaying merged commit b07ccfd into lf-edge:master-v2 Jul 2, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants