Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(io): restore edgex source/sink #2998

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Conversation

ngjaying
Copy link
Collaborator

@ngjaying ngjaying commented Jul 9, 2024

No description provided.

@ngjaying ngjaying force-pushed the v2edgex branch 2 times, most recently from a37db56 to cbc3503 Compare July 9, 2024 09:51
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 40.12500% with 479 lines in your changes missing coverage. Please review.

Project coverage is 67.60%. Comparing base (f2fdc02) to head (898c788).

Files Patch % Lines
internal/io/edgex/sink.go 42.08% 256 Missing and 11 partials ⚠️
internal/io/edgex/source.go 22.82% 151 Missing and 8 partials ⚠️
internal/io/edgex/client/edgex.go 46.88% 49 Missing and 2 partials ⚠️
internal/topo/planner/planner_source.go 89.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           master-v2    #2998      +/-   ##
=============================================
- Coverage      68.28%   67.60%   -0.68%     
=============================================
  Files            344      349       +5     
  Lines          33079    33868     +789     
=============================================
+ Hits           22586    22896     +310     
- Misses          8476     8933     +457     
- Partials        2017     2039      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying ngjaying force-pushed the v2edgex branch 3 times, most recently from 0c21288 to e74d3c6 Compare July 10, 2024 07:34
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying ngjaying force-pushed the v2edgex branch 3 times, most recently from 62473a7 to d2872cd Compare July 10, 2024 10:41
Streams shared the same subscriber need to set different emitter. So adding emitter op to do this.

Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying ngjaying marked this pull request as ready for review July 10, 2024 12:01
@ngjaying ngjaying requested a review from Yisaer July 10, 2024 12:02
@ngjaying ngjaying merged commit 64a121d into lf-edge:master-v2 Jul 15, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants