Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stop/delete rule should wait operator close #3056

Merged
merged 4 commits into from
Jul 26, 2024

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Jul 25, 2024

No description provided.

Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.95%. Comparing base (c11b697) to head (0c7a53b).

Files Patch % Lines
internal/server/server.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3056      +/-   ##
==========================================
+ Coverage   67.84%   67.95%   +0.11%     
==========================================
  Files         390      390              
  Lines       37135    37105      -30     
==========================================
+ Hits        25191    25211      +20     
+ Misses       9667     9620      -47     
+ Partials     2277     2274       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
@ngjaying ngjaying merged commit dd15c3c into lf-edge:master Jul 26, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants