Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conn): adapt all source/sink #3181

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Conversation

ngjaying
Copy link
Collaborator

@ngjaying ngjaying commented Sep 9, 2024

No description provided.

Signed-off-by: Jiyong Huang <huangjy@emqx.io>
Adapt to status change handler

Signed-off-by: Jiyong Huang <huangjy@emqx.io>
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 57.44681% with 60 lines in your changes missing coverage. Please review.

Project coverage is 71.07%. Comparing base (79cd2d6) to head (d60dbf1).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
extensions/impl/influx2/influx2.go 0.00% 8 Missing ⚠️
extensions/impl/zmq/sink.go 0.00% 7 Missing ⚠️
extensions/impl/zmq/source.go 0.00% 7 Missing ⚠️
extensions/impl/influx/influx.go 0.00% 6 Missing ⚠️
internal/io/memory/lookupsource.go 33.33% 3 Missing and 1 partial ⚠️
internal/io/redis/lookup.go 42.86% 3 Missing and 1 partial ⚠️
internal/io/redis/redisPub.go 42.86% 3 Missing and 1 partial ⚠️
internal/io/redis/redisSub.go 42.86% 3 Missing and 1 partial ⚠️
internal/io/redis/sink.go 42.86% 3 Missing and 1 partial ⚠️
extensions/impl/kafka/sink.go 62.50% 1 Missing and 2 partials ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3181      +/-   ##
==========================================
- Coverage   71.16%   71.07%   -0.09%     
==========================================
  Files         386      386              
  Lines       43290    43384      +94     
==========================================
+ Hits        30806    30834      +28     
- Misses      10051    10108      +57     
- Partials     2433     2442       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying marked this pull request as ready for review September 10, 2024 05:46
@ngjaying ngjaying merged commit aac0004 into lf-edge:master Sep 10, 2024
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants