Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: revise metrcis code #3428

Closed
wants to merge 7 commits into from
Closed

feat: revise metrcis code #3428

wants to merge 7 commits into from

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Dec 6, 2024

No description provided.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.30%. Comparing base (8b9042a) to head (4b247f1).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
internal/server/rule_init.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3428      +/-   ##
==========================================
+ Coverage   71.26%   71.30%   +0.04%     
==========================================
  Files         410      410              
  Lines       46831    46969     +138     
==========================================
+ Hits        33373    33488     +115     
- Misses      10846    10861      +15     
- Partials     2612     2620       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yisaer Yisaer marked this pull request as ready for review December 9, 2024 03:07
@Yisaer Yisaer requested a review from ngjaying December 9, 2024 03:07
Yisaer and others added 7 commits December 9, 2024 11:08
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
@Yisaer Yisaer closed this Dec 9, 2024
@Yisaer Yisaer deleted the metrics_2 branch December 16, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants