Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: revise metrics code #3430

Merged
merged 5 commits into from
Dec 12, 2024
Merged

feat: revise metrics code #3430

merged 5 commits into from
Dec 12, 2024

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Dec 9, 2024

No description provided.

Signed-off-by: Song Gao <disxiaofei@163.com>
@Yisaer Yisaer requested a review from ngjaying December 9, 2024 03:19
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.35%. Comparing base (4f2b159) to head (844beee).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
internal/server/rule_init.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3430      +/-   ##
==========================================
+ Coverage   71.33%   71.35%   +0.02%     
==========================================
  Files         411      412       +1     
  Lines       47112    47108       -4     
==========================================
+ Hits        33607    33612       +5     
+ Misses      10878    10873       -5     
+ Partials     2627     2623       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
@ngjaying ngjaying merged commit 1ebc3ae into lf-edge:master Dec 12, 2024
58 checks passed
@Yisaer Yisaer deleted the metrics_3 branch December 16, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants