Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(io): file source support inotify subscribe #3448

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ngjaying
Copy link
Collaborator

No description provided.

Signed-off-by: Jiyong Huang <huangjy@emqx.io>
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying ngjaying force-pushed the file branch 2 times, most recently from 8a7c2c7 to 8884a3d Compare December 18, 2024 01:17
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 8 lines in your changes missing coverage. Please review.

Project coverage is 71.45%. Comparing base (5084bb9) to head (ca1cb91).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
internal/io/file/watch.go 79.49% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3448      +/-   ##
==========================================
+ Coverage   71.33%   71.45%   +0.12%     
==========================================
  Files         411      413       +2     
  Lines       47157    47322     +165     
==========================================
+ Hits        33637    33811     +174     
+ Misses      10893    10880      -13     
- Partials     2627     2631       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying marked this pull request as ready for review December 18, 2024 09:06
@ngjaying ngjaying requested a review from Yisaer December 18, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant