attest : remove "storage" and "volume" from the field names #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proto/attest/attest.proto
Outdated
| ZAttestResponseCode response = 1; // Result of quote validation | ||
| bytes integrity_token = 2; // Valid if response is ATTEST_RESPONSE_SUCCESS, contains integrity token for device to | ||
| // Cache and present in the next config request | ||
| repeated AttestKey storage_keys = 3; // Valid if response is ATTEST_RESPONSE_SUCCESS, contain keys (recived encrypted |
proto/attest/attest.proto
Outdated
| ZAttestReqType reqType = 1; // type of the request | ||
| ZAttestQuote quote = 2; // attestation quote msg | ||
| repeated org.lfedge.eve.certs.ZCert certs = 3; // X509 certs in .PEM format, signed by device certificate | ||
| AttestStorageKeys storage_keys = 4; // encrypted secrets to be saved by the Controller, like encrypted keys for the volume storage vaults |
There was a problem hiding this comment.
Shouldn't this field also have "Storage" removed?
proto/attest/attest.proto
Outdated
| ATTEST_REQ_CERT = 1; // EVE X.509 certificates | ||
| ATTEST_REQ_NONCE = 2; // nonce request to Controller | ||
| ATTEST_REQ_QUOTE = 3; // quote msg from device | ||
| Z_ATTEST_REQ_TYPE_KEYS = 4; // to store device keys in Controller |
There was a problem hiding this comment.
Here STORE is a verb having nothing to do with storage, thus I think you should keep it.
proto/attest/attest.proto
Outdated
| ATTEST_RESP_CERT = 1; // response to cert msg | ||
| ATTEST_RESP_NONCE = 2; // response to quote request | ||
| ATTEST_RESP_QUOTE_RESP = 3; // response to quote msg | ||
| Z_ATTEST_RESP_TYPE_KEYS = 4; //response to Z_ATTEST_REQ_TYPE_KEYS |
shjala
force-pushed
the
generic_attest
branch
3 times, most recently
from
93859e5 to
10acaa1
Compare
Remove "storage" and "volume" from the field names, this is to make the field names more generic and not tied to storage or volume. This will make adding new keys to the attestation process easier. There has been no change in the wire format. Signed-off-by: Shahriyar Jalayeri <shahriyar@zededa.com>
shjala
force-pushed
the
generic_attest
branch
from
10acaa1 to
da1c41f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove "storage" and "volume" from the field names, this is to make the field names more generic and not tied to storage or volume. This will make adding new keys to the attestation process easier. There has been no change in the wire format.