Enabling hvc for KVM #1172
Merged
Enabling hvc for KVM #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Shaposhnik <rvs@zededa.com>
eriknordmark
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still testing it, so hold off on merging, but it is fully ready for review
This one moves us to using virtio-console as opposed to an emulated serial console for KVM domains. The virtio-console gets a fixed PCI ID #3 (hence renumbering of all PCI IDs in the tests) and is activated for all KVM domains. On the QEMU side we're now mapping that console to both a socket in the /run/hyperviosr/kvm/DOMAIN-NAME/cons AND to the stdout of the QEMU task. This has a nice benefit of collecting all the logs for the console in the cloud while at the same time allowing socat-style connection to the console for interactive debugging (your interactive shenanigans will be logged and sent to the cloud too!).
All of this allows us functionality that is on-part with Xen for containers AND also simplifies our life on ARM a great deal.