Blobs cleanup #2674
Merged
Blobs cleanup #2674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove blob and replace it with buildable artifact Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com>
giggsoff
force-pushed
the
remove-grub-blob
branch
from
2c1af5f to
9fa8eea
Compare
We can move from blobs to packages Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com>
giggsoff
force-pushed
the
remove-grub-blob
branch
from
9fa8eea to
1893419
Compare
eriknordmark
approved these changes
Jun 21, 2022
There was a problem hiding this comment.
LGTM.
In addition to testing on an RPI4, do we have some devices with atheros and TI wifi which we can use to check that they still work? I don't know which hardware those were added for. @rvs do you know?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can remove firmware blobs from the source tree in favor of alpine packages.
Also we can remove stage1 grub and use file from our build artifacts.