Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVE Build cosmetic changes #2677

Merged
merged 3 commits into from
Jun 16, 2022
Merged

EVE Build cosmetic changes #2677

merged 3 commits into from
Jun 16, 2022

Conversation

lmr
Copy link
Contributor

@lmr lmr commented Jun 16, 2022

Remove some of the noise on EVE build messages, to make it easier to tell apart real build issues and just small harmless failures.

lmr added 3 commits June 16, 2022 09:11
The package pkg/lisp was removed in b6d76be and the
script parse-pkgs.sh was not updated accordingly.
Let's update it now

Signed-off-by: Lucas Meneghel Rodrigues <lookkas@gmail.com>
The script likely referred to the Dockerfile.in in
the eve dir instead of pillar.

Signed-off-by: Lucas Meneghel Rodrigues <lookkas@gmail.com>
In order to reduce noise while investigating
build issues, let's modify the code of the
resolve_tags() function in such a way that
it doesn't print the error:

./tools/parse-pkgs.sh: line 54: $1: unbound variable

While it's being executed.

Signed-off-by: Lucas Meneghel Rodrigues <lookkas@gmail.com>
@lmr lmr requested review from eriknordmark and rvs as code owners June 16, 2022 09:15
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@eriknordmark eriknordmark merged commit 8b9463e into lf-edge:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants