Edgeview api addition and image build #2680
Conversation
naiming-zededa
commented
Jun 17, 2022
naiming-zededa
commented
- add eve build for edge-view
- add additional items in edge-view API to the controller
naiming-zededa
force-pushed
the
naiming-edgeview-api-add
branch
from
7ceee20 to
d029321
Compare
api/proto/config/edgeview.proto
Outdated
| // Ext debug policy applicable to edge-view | ||
| message ExtDebugAccessPolicy { | ||
| // external of device side of edge-view access is allowed or not |
There was a problem hiding this comment.
I understand what dev and app policies mean. What does "ext" mean? The comments are not clear.
Is this to access downstream aka southbound devices out e.g., eth1 on the EVE-OS edge-node?
There was a problem hiding this comment.
'ext' to mean the entity external to the device, e.g. a local-profile server on the LAN outside of mgmt or app-shared ports. since it's not part of EVE, and not part of EVE applications, so I think it should have it's own policy item. The current code, if tcp session setup is to an address we don't have, it has this:
https://github.com/lf-edge/eve/blob/master/pkg/edgeview/src/policy.go#L186
There was a problem hiding this comment.
Can you add that text as comments in the API.
I don't know if it would be more clear to call it "ExternalDevice" or "ExternalIP". Thoughts?
There was a problem hiding this comment.
may be 'ExternalEndPoints'
naiming-zededa
changed the title
Signed-off-by: Naiming Shen <naiming@zededa.com>
Signed-off-by: Naiming Shen <naiming@zededa.com>
naiming-zededa
force-pushed
the
naiming-edgeview-api-add
branch
from
d029321 to
12afbae
Compare
