Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wireguard module to kernel #2702

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Conversation

eriknordmark
Copy link
Contributor

This enables OCI contrainers running on EVE-OS to use wireguard.
Those are run using the same kernel as we have in the host.
At some point in time maybe we want a separate kernel for the host and the container runtime.

@eriknordmark eriknordmark requested review from deitch and giggsoff July 6, 2022 12:27
@eriknordmark eriknordmark requested a review from rvs as a code owner July 6, 2022 12:27
@eriknordmark eriknordmark requested a review from milan-zededa July 6, 2022 12:34
Copy link
Contributor

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although CI is not happy.

Copy link
Contributor

@giggsoff giggsoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust riscv64 kernel config: 0001-Fix-riscv64-kernel-config.txt

Copy link
Contributor

@zededa-yuri zededa-yuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding the

pkg/kernel/kernel_config-5.10.x-x86_64 Outdated Show resolved Hide resolved
@eriknordmark eriknordmark marked this pull request as draft September 7, 2022 17:17
Copy link

@zedi-pramodh zedi-pramodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rouming
Copy link
Contributor

rouming commented Nov 9, 2022

This seems to me partially copies #2711 . Still the same question: why do we need to load modules from the xen-tools container and not from a rootfs from a single place? It is already quite difficult to figure out the correct booting sequence and module order, and if containers start load modules (which are asynchronous to each other) - this gets really complicated and messy.

@eriknordmark eriknordmark marked this pull request as ready for review March 2, 2023 15:25
This enables OCI contrainers running on EVE-OS to use wireguard.

Signed-off-by: eriknordmark <erik@zededa.com>
Copy link

@zedi-pramodh zedi-pramodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark eriknordmark merged commit 0aaccfd into lf-edge:master Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants