-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wireguard module to kernel #2702
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although CI is not happy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please adjust riscv64 kernel config: 0001-Fix-riscv64-kernel-config.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind adding the
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
48600b7
to
8593903
Compare
This seems to me partially copies #2711 . Still the same question: why do we need to load modules from the xen-tools container and not from a rootfs from a single place? It is already quite difficult to figure out the correct booting sequence and module order, and if containers start load modules (which are asynchronous to each other) - this gets really complicated and messy. |
This enables OCI contrainers running on EVE-OS to use wireguard. Signed-off-by: eriknordmark <erik@zededa.com>
4f517e9
to
8f2bf4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This enables OCI contrainers running on EVE-OS to use wireguard.
Those are run using the same kernel as we have in the host.
At some point in time maybe we want a separate kernel for the host and the container runtime.